Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Server v1beta1 Go API definition #12529

Merged
merged 3 commits into from
May 1, 2024

Conversation

klingerf
Copy link
Contributor

The v1beta1 Go API definition for Servers was removed in #11920, in favor of the v1beta2 definition that was being added. For backwards compatibility, the v1beta1 definition should have been left in place.

I've split this change into two commits:

  • bb1cdcf: adds the API definition in controller/gen/apis/server/v1beta1
  • 7d7d23c: results of running bin/update-codegen.sh with the v1beta1 definition in place

The `v1beta1` Go API definition for Servers was removed in linkerd#11920, in
favor of the `v1beta2` definition that was being added. For backwards
compatability, the `v1beta1` definition should have been left in place.

Signed-off-by: Kevin Ingelman <[email protected]>
I've run `bin/update-codegen.sh` with the old Server `v1beta1` Go API
definition restored, to generate updating bindings.

Signed-off-by: Kevin Ingelman <[email protected]>
@klingerf klingerf requested a review from a team as a code owner April 30, 2024 21:32
In v1beta2, the Server CRD supports setting either `podSelector` or
`externalWorkloadSelector`, but not both. Therefore we should tag both
fields with `omitempty` for the purpose of serialization.

Signed-off-by: Kevin Ingelman <[email protected]>
@adleong adleong merged commit 5f068bf into linkerd:main May 1, 2024
37 checks passed
@klingerf klingerf deleted the ki/servers-v1beta1 branch May 1, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants